Create pyproject.toml and add python 3.12 to CI #2377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Right now installation fails on python 3.12 because distutils was removed. distutils are currently provided through the setuptools package. Using a pyproject.toml will tell modern python build tools to install setuptools prior to building capstone. I saw there is a separate PR to remove distutils, this is mostly orthogonal to that.
Once merged, I would like this cherry-picked to the v5 branch as well.
...
Test plan
Test that it builds and installs correctly on python 3.12. I've added an entry to the CI to ensure this.
...
Closing issues
Closes #2223
...